From 976e5563b75598c646a1f0eee1b9d6675af4d3b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E1=84=8B=E1=85=A2=E1=84=91=E1=85=B3=E1=86=AF=20=E1=84=82?=
 =?UTF-8?q?=E1=85=A9=E1=84=90=E1=85=B3=E1=84=87=E1=85=AE=E1=86=A8?=
 <jisangs@gmail.com>
Date: Thu, 17 May 2018 15:56:54 +0900
Subject: [PATCH] Fix: remove useless self variable

---
 src/game/lib/db_connect_manager.js | 50 ++++++++++++++----------------
 src/game/result/history_board.js   |  5 ++-
 src/game/result/ranking_board.js   |  5 ++-
 src/game/start/start.js            |  5 +--
 4 files changed, 29 insertions(+), 36 deletions(-)

diff --git a/src/game/lib/db_connect_manager.js b/src/game/lib/db_connect_manager.js
index fd9e47c..6e498c2 100644
--- a/src/game/lib/db_connect_manager.js
+++ b/src/game/lib/db_connect_manager.js
@@ -21,26 +21,8 @@ class DBConnectManager {
 	requestPlayerHistory(listener) {
 		let historyRecordManager = new HistoryRecordManager();
 
-		listener(historyRecordManager);
-	}
-
-	requestRanking(type, listener) {
-		let rankingRecordManager = new RankingRecordManager();
-
-		listener(rankingRecordManager);
-	}
-
-
-	requestTempPlayerHistory(listener) {
-		let historyRecordManager = new HistoryRecordManager();
-
-		historyRecordManager.push(new HistoryRecord("05/14", "space_invaders", 14460));
-		historyRecordManager.push(new HistoryRecord("05/13", "space_invaders", 12860));
-		historyRecordManager.push(new HistoryRecord("05/12", "typing_english_basic", 15460));
-		historyRecordManager.push(new HistoryRecord("05/11", "typing_korean_basic", 13040));
-		historyRecordManager.push(new HistoryRecord("05/10", "space_invaders", 15460));
-		historyRecordManager.push(new HistoryRecord("05/09", "typing_english_basic", 14607));
-		historyRecordManager.push(new HistoryRecord("05/08", "typing_korean_basic", 13058));
+		if(isDebugMode())
+			this.loadTempPlayerHistory(historyRecordManager);
 
 		if(listener === null)
 			return;
@@ -48,9 +30,30 @@ class DBConnectManager {
 		listener(historyRecordManager);
 	}
 
-	requestTempRanking(type, listener) {
+	requestRanking(type, listener) {
 		let rankingRecordManager = new RankingRecordManager();
 
+		if(isDebugMode())
+			this.loadTempRanking(rankingRecordManager);
+
+		if(listener === null)
+			return;
+
+		listener(rankingRecordManager);
+	}
+
+
+	loadTempPlayerHistory(historyRecordManager) {
+		historyRecordManager.push(new HistoryRecord("05/14", "space_invaders", 14460));
+		historyRecordManager.push(new HistoryRecord("05/13", "space_invaders", 12860));
+		historyRecordManager.push(new HistoryRecord("05/12", "typing_english_basic", 15460));
+		historyRecordManager.push(new HistoryRecord("05/11", "typing_korean_basic", 13040));
+		historyRecordManager.push(new HistoryRecord("05/10", "space_invaders", 15460));
+		historyRecordManager.push(new HistoryRecord("05/09", "typing_english_basic", 14607));
+		historyRecordManager.push(new HistoryRecord("05/08", "typing_korean_basic", 13058));
+	}
+
+	loadTempRanking(rankingRecordManager) {
 		rankingRecordManager.push(new RankingRecord(1, "강경모", 4400));
 		rankingRecordManager.push(new RankingRecord(2, "강성태", 3400));
 		rankingRecordManager.push(new RankingRecord(3, "김기덕", 2400));
@@ -67,11 +70,6 @@ class DBConnectManager {
 		rankingRecordManager.push(new RankingRecord(14, "합기도", 40));
 		rankingRecordManager.push(new RankingRecord(15, "우습지", 10));
 		rankingRecordManager.push(new RankingRecord(16, "하하하", 4));
-
-		if(listener === null)
-			return;
-
-		listener(rankingRecordManager);
 	}
 
 }
diff --git a/src/game/result/history_board.js b/src/game/result/history_board.js
index 831dccd..f4730af 100644
--- a/src/game/result/history_board.js
+++ b/src/game/result/history_board.js
@@ -13,14 +13,13 @@ class HistoryBoard {
 		this.textMyRanking = game.add.text(posX, posY + 100, '', arrayTabStyle)
 			.setShadow(3, 3, 'rgba(0, 0, 0, 0.5)', 2);
 
-		let self = this;
-		this.dbConnectManager.requestTempPlayerHistory( historyRecordManager => {
+		this.dbConnectManager.requestPlayerHistory( historyRecordManager => {
 			for(let i = 0; i < historyRecordManager.count; i++) {
 				if(i > 6)
 					break;
 
 				let data = historyRecordManager.getAt(i);
-				self.printRecord(i, data.date, data.score);
+				this.printRecord(i, data.date, data.score);
 			}
 		});
 	}
diff --git a/src/game/result/ranking_board.js b/src/game/result/ranking_board.js
index fcb8a1f..22d1989 100644
--- a/src/game/result/ranking_board.js
+++ b/src/game/result/ranking_board.js
@@ -13,14 +13,13 @@ class RankingBoard {
 
 
 	requestRanking(type, rankingRecordManager) {
-		let self = this;
-		this.dbConnectManager.requestTempRanking(type, rankingRecordManager => {
+		this.dbConnectManager.requestRanking(type, rankingRecordManager => {
 			for(let i = 0; i < rankingRecordManager.count; i++) {
 				if(i > 6)
 					break;
 
 				let data = rankingRecordManager.getAt(i);
-				self.printRecord(type, i, data);
+				this.printRecord(type, i, data);
 			}
 		});
 	}
diff --git a/src/game/start/start.js b/src/game/start/start.js
index fccab8d..3fde5f1 100644
--- a/src/game/start/start.js
+++ b/src/game/start/start.js
@@ -25,11 +25,8 @@ class Start {
 		// contents
 		this.printHowToPlay(appInfoManager.getHowToPlayText(sessionStorageManager.playingAppName));
 		this.makeStartButton();
-
 		this.printChartBaseLine();
-
-		let self = this;
-		this.dbConnectManager.requestTempPlayerHistory( historyRecordManager => {
+		this.dbConnectManager.requestPlayerHistory( historyRecordManager => {
 			let underValue = historyRecordManager.underValueForGraph();
 			let upperValue = historyRecordManager.upperValueForGraph();